Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render eml attachment #3416

Open
hoangdat opened this issue Jan 9, 2025 · 4 comments
Open

Render eml attachment #3416

hoangdat opened this issue Jan 9, 2025 · 4 comments
Assignees
Labels

Comments

@hoangdat
Copy link
Member

hoangdat commented Jan 9, 2025

Desc

  • user click on eml attachment directly, want to see the content of it
  • in mobile and web, we should open it directly. Not open it in any 3rd party apps
  • we also have option to download it in all platform

cf: gmail

Image

@chibenwa
Copy link
Member

chibenwa commented Jan 9, 2025

@chibenwa
Copy link
Member

chibenwa commented Jan 9, 2025

GIVEN I click on an EMLattachment then it opens it into a new TAB?

Front can call Email/parse to be able to work with this data (very similar to Email/get)

@hoangdat
Copy link
Member Author

hoangdat commented Jan 9, 2025

GIVEN I click on an EMLattachment then it opens it into a new TAB?

no, because we only to show it as a preview, to prevent more complicate actions: reply, replyAll, ... So maybe a kind of modal dialog which similar with pdf viewer.

@chibenwa
Copy link
Member

chibenwa commented Jan 9, 2025

Design: minimalist, GMail style

GIVEN this message:

image

When I forward it as attachment (in thunderbird):

signal-2025-01-09-085644

Then I see the mail as today

image

If I click the normal arow it dhowloads it

If I lick the chip it previews the email in a new TAB (title of the TAB is the subject of the email)

image

As simple as that, and we would be on par with GMail.


Edge cases: inlined email can have :

  • regular attachments
  • inlined attachments
  • other attached EML

The preview would need to handle this all...

Here is an EML for testing those edge cases:

vicous.eml.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants