Run golangci-lint on macOS and Windows; fix lint issues #3586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
force-pushed
the
chore/run-golangci-macos
branch
from
11e316a to
5d949a6
Compare
alexandear
changed the title
alexandear
force-pushed
the
chore/run-golangci-macos
branch
from
5d949a6 to
687debf
Compare
alexandear
changed the title
alexandear
force-pushed
the
chore/run-golangci-macos
branch
from
687debf to
34584e0
Compare
alexandear
changed the title
AkihiroSuda
reviewed
May 26, 2025
AkihiroSuda
reviewed
May 26, 2025
| return err | ||
| } | ||
| a.instSSHAddress = sshAddr | ||
| a.instSSHAddress = store.InstanceSSHAddress |
There was a problem hiding this comment.
GetSSHAddress for Unix and Windows is the same:
lima/pkg/store/instance_unix.go
Lines 14 to 16 in 7224ca4
lima/pkg/store/instance_windows.go
Lines 119 to 121 in 7224ca4
So, I decided to refactor and return "127.0.0.1" (const InstanceSSHAddress).
alexandear
force-pushed
the
chore/run-golangci-macos
branch
6 times, most recently
from
f07eb9f to
ad59340
Compare
AkihiroSuda
reviewed
May 27, 2025
.github/workflows/test.yml
Outdated
| timeout-minutes: 30 | ||
| strategy: | ||
| matrix: | ||
| runs-on: [ubuntu-24.04, macos-15-large, windows-2022-8-cores] |
There was a problem hiding this comment.
No need to use larger instances?
alexandear
force-pushed
the
chore/run-golangci-macos
branch
8 times, most recently
from
917eb08 to
666e2c3
Compare
alexandear
force-pushed
the
chore/run-golangci-macos
branch
from
666e2c3 to
2673f4c
Compare
Signed-off-by: Oleksandr Redko <[email protected]>
alexandear
force-pushed
the
chore/run-golangci-macos
branch
from
2673f4c to
4ea83b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
golangci-lintstep to run on Windows and macOS. And fixes a few lint issues that appeared on Windows and macOS.Fixes #3585