Revert virtserialport back to unix socket for QEMU guest agent communication #2112
Conversation
| @@ -128,7 +128,8 @@ func New(instName string, stdout io.Writer, sigintCh chan os.Signal, opts ...Opt | |||
| } | |||
| vSockPort = port | |||
| } else if *y.VMType == limayaml.QEMU { | |||
| virtioPort = filenames.VirtioPort | |||
| // virtserialport doesn't seem to work reliably: https://github.com/lima-vm/lima/issues/2064 | |||
There was a problem hiding this comment.
Could you report this to https://gitlab.com/qemu-project/qemu/-/issues ?
There was a problem hiding this comment.
Not sure what exactly I would report; I have no more information beyond that the code in Lima sometimes fails. It doesn't even fail reliably, which is why the bisect script restarts the VM up to 100 times before accepting that the code works properly.
I haven't checked if the problem happens on the sending or the receiving side, as we are not getting any errors.
So I feel this would need some more investigation before reporting to upstream, but unfortunately I'm out of time right now. 😞
jandubois
force-pushed
the
qemu-guestagent-socket
branch
from
a8ef354 to
61cf141
Compare
|
Shall we release a new version after merging this? |
|
Converted to draft because it only works properly with Ubuntu, but not with Alpine. Will investigate... |
…ication The serial port sometimes doesn't seem to work: lima-vm#2064 Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
qemu-guestagent-socket
branch
from
61cf141 to
9e1a07a
Compare
I think I fixed it now (just some quoting issues in |
Seems to work fine with Alpine as well now.
I think so, as running into the flakiness is annoying, and not immediately obvious if it is your fault or not. Don't really care about the version 0.19.2 vs. 0.20.0; either one works for me. |
| @@ -128,7 +128,8 @@ func New(instName string, stdout io.Writer, sigintCh chan os.Signal, opts ...Opt | |||
| } | |||
| vSockPort = port | |||
| } else if *y.VMType == limayaml.QEMU { | |||
| virtioPort = filenames.VirtioPort | |||
| // virtserialport doesn't seem to work reliably: https://github.com/lima-vm/lima/issues/2064 | |||
| virtioPort = "" // filenames.VirtioPort | |||
There was a problem hiding this comment.
Re-assigning the empty string here to satisfy the linter; couldn't get it to shut up blathering about empty branches and empty blocks if I left everything commented out...
|
@balajiv113 LGTY? |
The serial port sometimes doesn't seem to work: #2064.
The vsock implementation used for VZ doesn't seem to have this problem.
It makes sense to revert to the old mechanism for QEMU until the serialport has been fixed (if possible).
Just commenting out the virtioPort will fall back to the old socket method thanks to #2006.