Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++17 lambda + parallel #154

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Artoria2e5
Copy link
Contributor

I am not sure how much slower/faster the lambda paradiam is, so let's be safe and run the comparison before we decide whether the old impl should be kept.

I am not sure how much slower/faster the lambda paradiam is, so let's be
safe and run the comparison before we decide.
@lilydjwg
Copy link
Owner

You forgot to update benchmark.toml. Also can you update countlines?

A colon in the name is now understood to not change the $name attribute.

The TOML has been updated for C++17.
bench.py Outdated
@@ -117,7 +117,8 @@ def load_config():
profile['name'] = name
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this line be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Just because we are defining ${name} as meaning "name without the front part" does not mean we can leave it undefined in the dict.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But won't there be multiple name arguments passed into safe_substitute?

C++17/Makefile Outdated

swapview-par-lam: swapview.cpp
$(CXX) swapview.cpp -o swapview-par-lam $(PAR) $(LAM) $(CXXFLAGS)
strip swapview
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above is stripping a wrong binary.

@lilydjwg
Copy link
Owner

lilydjwg commented Apr 2, 2020

This doesn't compile (C++17) with latest gcc / g++ from Arch. Is there anything missed or changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants