Bug fix in background signature estimation #317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When estimating background signature given a sparse count matrix, in
pegasus.cylib.calc_sig_background_sparse
function, the calculation ignores zero entries of the matrix, while their centered expression should be considered because the gene mean expressions are likely non-zero.However, if given a dense count matrix, the calculation does not have this issue since it uses a different Cython function
pegasus.cylib.calc_sig_background_dense
.Solution
Include all entries during the calculation, with tricks to speed up.
Other improvement
Add
standardize
parameter tocalc_signature_score
function to allow return non-standardized signature scores. By default, standardize the scores.