NFT & ISCN table #27
Merged
NFT & ISCN table #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add begin, end to do pagination
+ using handlers models + process every message in an tx
move Extractor function to db
+ move createNftClass sql to db + add sql/reset.sql for easily reset db
nnkken
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
I have some concern on the performance on the ranking query, since it needs joining 4 tables (nft, nft_class, nft_events, iscn) and we need something like COUNT(nft_events) for ranking by NFT trade counts.
Not sure whether we can accomplish this by simply using this schema, or by another extractor for this query.
williamchong
requested changes
Jul 17, 2022
after, before -> next_key order -> reverse
+ add liked command in test/
nnkken
reviewed
Jul 20, 2022
williamchong
requested changes
Jul 25, 2022
| "/likechain.iscn.MsgChangeIscnRecordOwnership": transferISCN, | ||
| "new_class": createNftClass, | ||
| "mint_nft": mintNft, | ||
| "/cosmos.nft.v1beta1.MsgSend": sendNft, |
There was a problem hiding this comment.
what if we query account based nft class?
williamchong
approved these changes
Jul 25, 2022
👽️ Modify path according to x/likenft path
remove panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISCN
iscntable extracted from txsmetatable to record synced height of iscnother changes:
NFT
/likenft/class?iscn_id_prefix=&expand=取得單一 ISCN 的所有 NFT Classes，加上 expand 可以展開 class 底下的 NFT https://nft-dev.wancat.cc/likenft/class?iscn_id_prefix=iscn://likecoin-chain/LfNpeWjRHC8NncTZNZ1pJlWDvApnESJCU9b6zVkzEq4/likenft/nft?owner=取得一個 owner 有的 NFT 清單 https://nft-dev.wancat.cc/likenft/nft?owner=like1qv66yzpgg9f8w46zj7gkuk9wd2nrpqmca3huxf/likenft/owner?class_id=取得一個 NFT Class 的擁有者名單以及他們持有的 NFT https://nft-dev.wancat.cc/likenft/owner?class_id=likenft1ewcmlx4kq4uwctmz08zs6kh5s9te4g6nghrz8rwdharpd6wsxe4s0zgjlj/likenft/event?class_id=&nft_id=&iscn_id_prefix=&verbose=取得 events （包含 NFT Class 的所有 events）