Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TAS-691] 🚑️ Fix Android cannot complete WC in webview, support intent:// #402

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[TAS-691] 🚑️ Fix Android cannot complete WC in webview, support intent:// #402

merged 1 commit into from
Nov 9, 2023

Conversation

williamchong
Copy link
Member

No description provided.

@williamchong williamchong marked this pull request as ready for review November 9, 2023 13:00
nwingt
nwingt approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@nwingt nwingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be graceful if absolute imports are put before relative imports🙏🏻

@williamchong
Copy link
Member Author

Would be graceful if absolute imports are put before relative imports🙏🏻

updated

@nwingt nwingt changed the title 🚑️ Fix android cannot complete wc in webview, support intent:// 🚑️ Fix Android cannot complete WC in webview, support intent:// (#402) Nov 9, 2023
@nwingt nwingt changed the title 🚑️ Fix Android cannot complete WC in webview, support intent:// (#402) 🚑️ Fix Android cannot complete WC in webview, support intent:// Nov 9, 2023
@nwingt nwingt changed the base branch from develop to release/v0.35.1 November 9, 2023 15:21
@nwingt nwingt merged commit 1faf4f4 into likecoin:release/v0.35.1 Nov 9, 2023
2 checks passed
@williamchong williamchong changed the title 🚑️ Fix Android cannot complete WC in webview, support intent:// [TAS-691] 🚑️ Fix Android cannot complete WC in webview, support intent:// Nov 16, 2023
@notion-workspace Notion Workspace
Copy link

Fix android inapp wallet connect issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwingt nwingt nwingt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@williamchong @nwingt