Fix installation and build using luarocks #33
+23
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luarocks documentation has been moved from Github's wiki [1] to repository [2]. The patch fixes a link to description of rockspec file format. 1. https://github.com/luarocks/luarocks/wiki/ 2. https://github.com/luarocks/luarocks/blob/main/docs/index.md
The patch sets all libraries for custom_mutator library in a one go.
The patch fixes regular expression that replaces branch and version in rockspec before publishing. Regular expression uses single quotes, but rockspec uses double quotes and this leads to broken version and branch update. Follows up commit 866620f ("ci: update publishing steps").
The patch fixes a broken build testing steps. The commit e52d181 ("Initial version") introduced a versioning for `libcustom_mutator` shared library, but seems it is not actually needed and `SOVERSION` has been removed. The patch also added a test that installs the module using luarocks, set environment variables using luarocks and checks that module was successfully found by Lua interpreter. Fixes #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Fixes #4