Fix integer overflow in consume_integer() #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligurio
changed the title
Buristan
reviewed
Apr 7, 2025
Buristan
suggested changes
Apr 7, 2025
ligurio
force-pushed
the
ligurio/gh-29-integer-overflow
branch
8 times, most recently
from
4843836 to
8f3e5bc
Compare
Reported by cppcheck.
Follows up commit d2cb24d ("luzer: introduce oneof() in FuzzedDataProvider").
ligurio
force-pushed
the
ligurio/gh-29-integer-overflow
branch
2 times, most recently
from
dba9490 to
2f08948
Compare
ligurio
force-pushed
the
ligurio/gh-29-integer-overflow
branch
4 times, most recently
from
df0fe40 to
2564876
Compare
The implementation of FDP methods `consume_integer()` and `consume_integers()` have used type `int` for passed arguments in aforementioned functions. This leads to integer overflow. Fixes #29
The implementation of FDP methods `consume_number()` and `consume_numbers()` are used type `double` for arguments of aforementioned functions. The Lua type `lua_Number` can be not a `double` and it is defined compile-time. The patch replaces `double` with `lua_Number` to avoid overflows. Follows up #29
ligurio
force-pushed
the
ligurio/gh-29-integer-overflow
branch
from
2564876 to
b694d25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29