Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the support for mimalloc, a better memory allocator. It has been claimed by authors that this outperforms other allocators including TCMalloc, but whether this applies to KataGo as well is beyond me.
I have confirmed that this can be built and run on both Windows and *NIX systems. Due to the problem of mimalloc itself,
ld
cannot correctly search the shared library file when mimalloc is installed withmake install
in *NIX, andLD_LIBRARY_PATH
should be set properly (likeexport LD_LIBRARY_PATH=/usr/local/lib/mimalloc-1.7/:$LD_LIBRARY_PATH
) before running KataGo.Presumably the official windows binary can be built with this, and
mimalloc-override.dll
,mimalloc-redirect.dll
, and a corresponding license file can be provided.