[core] fix GError leak

Change-Id: I581d34880a4a592a6f81c49c21e95c7fb0061db6
lighttpd · Feb 6, 2024 · 1735f55 · 1735f55
1 parent 2b4e6d3
commit 1735f55
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/common/module.c b/src/common/module.c
@@ -74,6 +74,7 @@ liModule* li_module_load(liModules *mods, const gchar* name, GError **err) {
 	mod->module = g_module_open(mod->path, G_MODULE_BIND_LAZY);
 
 	if (!mod->module) {
+		/* remember original error if second try fails too */
 		if (err) g_set_error(err, LI_MODULES_ERROR, 1, "%s", g_module_error());
 		g_free(mod->path);
 
@@ -86,6 +87,12 @@ liModule* li_module_load(liModules *mods, const gchar* name, GError **err) {
 			g_slice_free(liModule, mod);
 			return NULL;
 		}
+
+		/* it worked out, clean error */
+		if (err) {
+			g_error_free(*err);
+			*err = NULL;
+		}
 	}
 
 	/* temporary strings for mod_xyz_init and mod_xyz_free */