browser context proxyServer #789
Merged
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorsdonkers
force-pushed
the
browsercontext-proxyServer
branch
from
3ad7936 to
6f5141d
Compare
sjorsdonkers
commented
Jun 17, 2025
Comment on lines
+86
to
+89
| // For now the http client is not in the browser context so we assume there is just 1. | ||
| bc.http_proxy_before = cmd.cdp.browser.http_client.http_proxy; | ||
| const proxy_cp = try cmd.cdp.browser.http_client.allocator.dupe(u8, proxy); | ||
| cmd.cdp.browser.http_client.http_proxy = try std.Uri.parse(proxy_cp); |
There was a problem hiding this comment.
Is this too hacky? 🧐
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we rely on there existing only 1 browser context. We just need to make sure that we set it back after the session ends
Additional:
Should we rename
--http-proxyto--proxy-serverto align with chromium?