Skip to content

Always add the payment address when probing an invoice #10439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyforyongyu merged 2 commits into from
Dec 10, 2025
Merged

Always add the payment address when probing an invoice #10439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c4bcc3
routerrpc: fix payment address deep copy
ziggie1984 Dec 10, 2025
ac30443
docs: add release-notes for LND 20.1
ziggie1984 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/release-notes/release-notes-0.20.1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@
issue](https://github.com/lightningnetwork/lnd/pull/10428) in LND which might
happen when running postgres with a limited number of connections configured.

* [Add missing payment address/secret when probing an
invoice](https://github.com/lightningnetwork/lnd/pull/10439). This makes sure
the EstimateRouteFee API can probe Eclair and LDK nodes which enforce the
payment address/secret.

# New Features

## Functional Enhancements
Expand Down
5 changes: 5 additions & 0 deletions lnrpc/routerrpc/router_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,7 @@ func (s *Server) probePaymentRequest(ctx context.Context, paymentRequest string,
// If the payment addresses is specified, then we'll also populate that
// now as well.
payReq.PaymentAddr.WhenSome(func(addr [32]byte) {
probeRequest.PaymentAddr = make([]byte, lntypes.HashSize)
copy(probeRequest.PaymentAddr, addr[:])
})

Expand Down Expand Up @@ -624,6 +625,10 @@ func (s *Server) probePaymentRequest(ctx context.Context, paymentRequest string,

// Copy the payment address if present.
if len(probeRequest.PaymentAddr) > 0 {
lspProbeRequest.PaymentAddr = make(
[]byte, lntypes.HashSize,
)

copy(
lspProbeRequest.PaymentAddr,
probeRequest.PaymentAddr,
Expand Down
Loading