Skip to content

Conversation

@tnull
Copy link
Contributor

@tnull tnull commented Nov 27, 2025

Previously, we logged "Persisting LiquidityManager..." on each background processor wakeup, which can be very spammy, even on TRACE level.

Here, we opt to only log if something actually needed to be repersisted and we did so (in case of failure we're logging that anyways, too).

@tnull tnull requested a review from TheBlueMatt November 27, 2025 08:59
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 27, 2025

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Previously, we logged "Persisting LiquidityManager..." on each
background processor wakeup, which can be very spammy, even on TRACE
level.

Here, we opt to only log if something actually needed to be repersisted
and we did so (in case of failure we're logging that anyways, too).
@tnull tnull force-pushed the 2025-11-less-spammy-liqman-persistence branch from fc07160 to 369ea98 Compare November 27, 2025 09:03
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.32%. Comparing base (bb5504e) to head (369ea98).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lightning-background-processor/src/lib.rs 46.15% 4 Missing and 3 partials ⚠️
lightning-liquidity/src/lsps2/service.rs 50.00% 3 Missing ⚠️
lightning-liquidity/src/manager.rs 57.14% 0 Missing and 3 partials ⚠️
lightning-liquidity/src/lsps5/service.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4246      +/-   ##
==========================================
- Coverage   89.33%   89.32%   -0.01%     
==========================================
  Files         180      180              
  Lines      138680   138745      +65     
  Branches   138680   138745      +65     
==========================================
+ Hits       123888   123939      +51     
- Misses      12172    12178       +6     
- Partials     2620     2628       +8     
Flag Coverage Δ
fuzzing 36.00% <ø> (+0.01%) ⬆️
tests 88.69% <57.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants