Rustfmt chainmonitor.rs

[joostjager]

I badly miss rustfmt for my changes in #3778.

The larger strategy for rustfmt is still being discussed (#3749, #3809), but getting this one with immediate benefit through would be great.

[ldk-reviews-bot]

👋 Thanks for assigning @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

[TheBlueMatt]

Presumably we should just format all of chainmonitor.rs in one go? Its only 1200 lines and not very actively edited, why bother with an iterative approach?

[joostjager]

Happy to do that. I just wanted to be conservative and only format the parts that I touch.

[joostjager]

Pushed full rustfmt'ed chainmonitor

[valentinewallace]

I'm fine to do these in follow-up if you want to Just Land

[valentinewallace]

nit: extract into var

[valentinewallace]

Based on CI failures, looks like you might have to extract only self.monitors.read().unwrap()

[joostjager]

Indeed. Done

[valentinewallace]

I'd prefer:

		for channel_id in mons_to_process {
			let mut ev;
			let monitor = self.monitors.read().unwrap().get(&channel_id).map(|m| &m.monitor);
			let res = process_events_body!(monitor, self.logger, ev, handler(ev).await);
			match res {
				Ok(()) => {},
				Err(ReplayEvent()) => {
					self.event_notifier.notify();
				},
			}
		}

with importing process_events_body

[joostjager]

This starts to complain about borrow from a temporary value. Left as is, this is formatting only?

[TheBlueMatt]

Certainly if you don't want to bother cleaning things up we can just land a subset that doesn't need it and come back to it later, I was just suggesting it probably wasn't much effort to clean up as we went given the file's size.

[joostjager]

Right. Yes, the clean up is kind of subjective, so wanted to avoid that. But will now go with @valentinewallace's suggestions above.

[joostjager]

Rebased