Skip to content

Add option to generate outbound scid alias using intercept namespace #3839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

aylagreystone
Copy link

Introduces a flag on ChannelHandshakeConfig that can be set to enable outbound scid alias generation to use the intercept namespace. This would allow users to selectively enable interception on channels and get HtlcIntercepted events for every payment forwarded on those channels.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jun 9, 2025

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.84%. Comparing base (0848e7a) to head (363cf07).
Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/util/config.rs 25.00% 1 Missing and 2 partials ⚠️
lightning/src/ln/channelmanager.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3839      +/-   ##
==========================================
- Coverage   89.88%   89.84%   -0.04%     
==========================================
  Files         160      160              
  Lines      129654   129670      +16     
  Branches   129654   129670      +16     
==========================================
- Hits       116534   116507      -27     
- Misses      10425    10458      +33     
- Partials     2695     2705      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aylagreystone aylagreystone force-pushed the intercept-alias branch 3 times, most recently from c2cf0b5 to 5b1d52f Compare June 9, 2025 21:45
@tnull tnull requested review from tnull and removed request for valentinewallace June 10, 2025 07:59
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on Discord, I don't think we should extend the intercept SCID concept much further. If we want to do generalized HTLC interception (#2855), we should finally do it 'properly', i.e., create an interface (e.g., a trait) that would allow users to intercept all HLTCs and then return an action to be taken. This could for example be similar to what CLN does with its hooks.

@tnull
Copy link
Contributor

tnull commented Jun 12, 2025

Going ahead and closing this as it has been superseded by the draft at #3843.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants