-
Notifications
You must be signed in to change notification settings - Fork 407
Exchange splice_locked
messages
#3741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jkczyz
wants to merge
28
commits into
lightningdevkit:main
Choose a base branch
from
jkczyz:2025-04-splice-locked
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+758
−258
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
7991c04
Generalize do_chain_event signature for splicing
jkczyz d590e2a
Move ChannelContext::funding_tx_confirmed_in to FundingScope
jkczyz 11027f4
Move ChannelContext::funding_tx_confirmation_height to FundingScope
jkczyz 51e300c
Move ChannelContext::short_channel_id to FundingScope
jkczyz 682c459
Refactor funding tx confirmation check into helper
jkczyz 7c872ae
Check FundingScope::funding_transaction for coinbase tx
jkczyz 44671ae
Add FundingScope::get_funding_txid helper
jkczyz 32f0f6b
Reset FundingScope::funding_tx_confirmation_height
jkczyz f1f5f1b
f - fix outdated comment
jkczyz 451c60e
Special case 0-conf in check_funding_meets_minimum_depth
jkczyz 2a31392
Check confirmation of pending funding transactions
jkczyz d6e26d7
f - error when pending_splice is None
jkczyz fdf11cb
f - add docs
jkczyz a0cd76c
f - use early return instead of is_funding_tx_confirmed
jkczyz 5208684
f - skip check_for_funding_tx_spent
jkczyz bd27310
f - DRY splice funding promotion
jkczyz 5238bdb
Move check_funding_meets_minimum_depth to FundedChannel
jkczyz c49f632
Account for coinbase tx in ChannelContext::minimum_depth
jkczyz ba60013
Check unconfirmation of pending funding transactions
jkczyz de53a88
f - fix compilation error
jkczyz 8fe756f
Check all FundingScopes in get_relevant_txids
jkczyz ea6ab03
Handle splice_locked message
jkczyz 50db5cc
f - proper return values
jkczyz 89e7aa1
Track historical SCIDs from previous funding
jkczyz 07908cf
f - add CHANNEL_ANNOUNCEMENT_PROPAGATION_DELAY const
jkczyz a06a7de
f - look at next SCID when retaining previous
jkczyz 0cb7874
Emit SpliceLocked event
jkczyz 61fcbfc
Add funding_txo to ChannelReady event
jkczyz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.