Skip to content

Allow unknown config options in client#218

Merged
benthecarman merged 2 commits into
lightningdevkit:mainfrom
benthecarman:fix-cli-cfg
May 22, 2026
Merged

Allow unknown config options in client#218
benthecarman merged 2 commits into
lightningdevkit:mainfrom
benthecarman:fix-cli-cfg

Conversation

@benthecarman
Copy link
Copy Markdown
Collaborator

Bug accidentally introduced in #216, now tests will catch

We purposely don't parse the entire the config in the client, only the things releveant to the client. When we added the denys in e5eccc1 we now will fail with a normal config because our cli will throw an error for the config options we don't parse in the client.

We purposely don't parse the entire the config in the client, only the
things releveant to the client. When we added the denys in
e5eccc1 we now will fail with a normal
config because our cli will throw an error for the config options we
don't parse in the client.
Exercise the CLI against the server-generated config file so e2e tests
cover client-side parsing of daemon config sections. Rebuild the e2e CLI
binary when the client crate changes so this path cannot use stale code.
@benthecarman benthecarman requested a review from tankyleo May 22, 2026 21:06
@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented May 22, 2026

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo
Copy link
Copy Markdown
Contributor

Bug accidentally introduced in #216, now tests will catch

We purposely don't parse the entire the config in the client, only the things releveant to the client. When we added the denys in e5eccc1 we now will fail with a normal config because our cli will throw an error for the config options we don't parse in the client.

Ah my bad, I was still in the old world where we have ldk-server-config.toml !

So I thought clients just had a separate configuration file called config.toml. I did not understand config.toml is now also the config file for ldk-server :)

@benthecarman benthecarman merged commit 3f98b85 into lightningdevkit:main May 22, 2026
10 checks passed
@benthecarman benthecarman deleted the fix-cli-cfg branch May 22, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants