Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Make sure the provided image does not overflow the iOS' metal size. #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cristianoccazinsp
Copy link

@rodymolenaar I've just discovered that iOS may blow up when given large images, and it will vary from device to device.

On an iPhone 12 pro, the error will be:
Texture Descriptor Validation MTLTextureDescriptor has width (18240) greater than the maximum allowed size of 16384.

On an iPhone 7 the value was the same, which is odd, but I guess it depends on a combination of hardware and software.

The fix is to just resize the image if it is too large for the device to handle. The actual metal buffer max size is not constant and not directly exposed to the code, but I grabbed an idea from here https://stackoverflow.com/questions/58366416/how-to-get-programmatically-the-maximum-texture-size-width-and-height which seems to work.

Happy new year by the way!

@cristianoccazinsp cristianoccazinsp changed the title Make sure the provided image does not overflow the GPU metal size. Make sure the provided image does not overflow the iOS' metal size. Dec 30, 2021
@cristianoccazinsp
Copy link
Author

@rodymolenaar any thoughts on this one?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants