Mordernizing demo #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP This is a first commit on the way from 2.5 to Lift 3.1. At this point we have moved to 3.1 but some scala files is remed and awaits porting to 3.1. The new layout is now responsive and uses Bootstrap v4 but the look is stil simular to the original. ToDo's is plenty, see Notes.md for more info.
WIP This is a first commit on the way from 2.5 to Lift 3.1. At this point we have moved to 3.1 but some scala files is remed and awaits porting to 3.1. The new layout is now responsive and uses Bootstrap v4 but the look is stil simular to the original. ToDo's is plenty, see Notes.md for more info.
Work done on 'Home', 'Interactive Stuff', 'Persistence' and 'Templating' sections up to 'Templating Embed'
Work done mostly on templating and web services sections.
Making mobile view of messages more readable by adding lift messages to the top of the page.
Replacing deprecated and removed scala code with css selector alternatives, plus some rendom cleanup.
Adding font awesome v5.5.0 using it's svg images.
Makes Lift version and build information shown in the app work again.
The FoBo module usage has been reduced to only load it's bootstrap 4 API.
|
I found this PR really useful in reviving a derelict Lift app of mine - thanks! The demo works great ( |
|
God to hear that you found it useful,
yes my server is down and has been for a couple of weeks now as I (and my
family) have been buzzy moving to a new location.
I will eventually get around to set it up again ;)
best regards Peter
Den mån 1 juli 2019 kl 14:01 skrev Luke Nezda <[email protected]>:
… I found this PR really useful in reviving a derelict Lift app of mine -
thanks! The demo works great (sbt jetty:run). The progress demo link
http://www.media4u101.se/demo/ isn’t available (nor is the related FoBo
one http://www.media4u101.se/fobo-lift-template-demo/).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#4?email_source=notifications&email_token=AAF3LJYUSZBDYVIRT7B53RTP5HWZBA5CNFSM4EC3LNEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY54ZEY#issuecomment-507235475>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF3LJ2H7F4PKVGMSCGO3BLP5HWZBANCNFSM4EC3LNEA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIFT DEMO MODERNIZING
This PR is about modernizing the lift demo by moving it from Lift v2.5 to Lift v3.3 and making it responsive and more mobile friendly.
At this point Scala/Lift files code has been ported to Lift v3.3 and most template files has been converted from XHTML syntax to HTML5 backed by Lift's CSS Selector Transforms.
The layout (design) is now responsive and uses Bootstrap v4, the look is similar to the original.
Note: The app is runnable so you are welcome to check it out and give feedback.
Progress so far (may be lagging) can also be seen at http://www.media4u101.se/demo/.
This PR will eventually (if all goes well) replace the Lift v2.5 based content at https://demo.liftweb.net/
Notable changes/updates
Sections (checked equals ~done)
Additional improvements
Interactive Stuff
Need help with JSON Messaging and More JSON pages / functions.
Persistence
The Templating page has been removed as it relies on BindHelpers that is no more in Lift v3 need to look in to this to see if it makes sense to rewrite and add it back.