LPD-24670 | Inform about Data Sets without visualization mode when selecting Data Set #5122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
|
Test suite sf has been triggered on http://test-1-38 |
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesRan com.liferay.source.formatter at released version 1.0.1543. Click here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-24670 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#6642 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#5122 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - chestofwonders > liferay-frontend - PR#5122 - 2025-10-10[03:20:25] Testray Build ID: 336937551Testray Importer:test-portal-source-format#6642 |
chestofwonders
requested review from
dsanz,
juanjofgliferay and
markocikos
and removed request for
liferay-frontend
Closed
|
@chestofwonders pls check comment on old, draft PR Also, pls remove "WIP" from commit message :) |
… of list we need to mutate item as ClayList.Item does not take any prop we can remap.
…ormer to the parent component. This assumes it makes no sense to manage <ClayList.Item> props directly
chestofwonders
force-pushed
the
LPD-24670
branch
from
df578cf to
63f950e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://liferay.atlassian.net/browse/LPD-24670
See #5110 for previous discussion
Inform about Data Sets without visualization mode when selecting Data Set
The goal of this PR is to warn the user when selecting a Data Set from the list to display in a fragment, that there are Data Set that will not be able to be displayed on the page, since no visualization modes have been defined for them.
Also, a tooltip is show when user hovers the cursor over the warning icon