LPD-52709 Part 6: language request handler #5116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that we are not hashing the file names yet because they rely on Java tooling but at least we leverage the new configurable time based caching infrastructure.
Note that for some bundles we also hashify the file names to achieve infinite caching.
Note that we are not hashing the file names yet because that needs changes in the tooling, but at least we leverage the new configurable time based caching infrastructure.
We need to use language labels modules for caching to be feasible.
…rnals Since we will be splitting .js modules in two parts: code itself and labels in a different file, we don't need the LanguageFilter any more. This will make the use of ETags for .js files not necessary any more.
We will integrate all resources managed by frontend-js-web in a single filter that will delegate to request helpers in the next commit. This is to be able to centralize all frontend resources management (CSS, JS, source maps, etc) in one place and reuse strategies for serving them.
|
CI is automatically triggering the following test suites:
|
|
Test suite sf has been triggered on http://test-1-32 |
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesRan com.liferay.source.formatter at released version 1.0.1543. Click here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-52709-6 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#10899 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#5116 Testray Routine:EE Pull Request Testray Build ID: 335561160Testray Importer:test-portal-source-format#10899 |
|
ci:test:sf |
|
Test suite sf has been triggered on http://test-1-30 |
liferay-continuous-integration
added
ci:test:sf - pending
and removed
ci:test:sf - success
labels
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutesRan com.liferay.source.formatter at released version 1.0.1543. Click here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-52709-6 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#7349 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#5116 Testray Routine:EE Pull Request Testray Build ID: 336218086Testray Importer:test-portal-source-format#7349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.