Skip to content

LPP-60517 Solution PoC #5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

LPP-60517 Solution PoC #5076

wants to merge 2 commits into from

Conversation

izaera
Copy link
Collaborator

@izaera izaera commented Sep 15, 2025 •
edited
Loading

This is a draft PR with the solution for LPP-60517.

It makes all JS import map contributors use the AbsolutePortalURLBuilder so that CDN is prepended to URLs when configured.

Let's see what CI has to say about it.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

@izaera
Copy link
Collaborator Author

izaera commented Sep 15, 2025

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

Test suite relevant has been triggered on http://test-1-27

@liferay-continuous-integration
Copy link
Collaborator

Test suite sf has been triggered on http://test-1-27

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Ran com.liferay.source.formatter at released version 1.0.1535.
*The latest version has not been released.

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b8ffc3ea27fa379a103881d9d97110ffafb33ca8

Sender Branch:

Branch Name: LPP-60517
Branch GIT ID: 31406f5c2ab58b484c6b2ebebb95c7ede8485803

0 out of 1 jobs PASSED
For more details click here.
format-source-files:
     [java] java.lang.Exception: Found formatting issue in SHA 31406f5c2ab58b484c6b2ebebb95c7ede8485803
     [java] The commit message is missing a reference to a required JIRA project: BLADE, CLDSVCS, COMMERCE, FACES, IDE, ISSD, ISSITES, LCD, LHC, LOOP, LPD, LPS, LRAC, LRCI, LRDOCS, LRIS, LRQA, LRSD, OAUTH2, POSHI, RELEASE, SYNC, TR. Please verify that the JIRA project keys are specifiedin source-formatter.properties in the liferay-portal repository.
     [java]   at com.liferay.source.formatter.util.JIRAUtil.validateJIRAProjectNames(JIRAUtil.java:62)
     [java]   at com.liferay.source.formatter.SourceFormatter._validateCommitMessages(SourceFormatter.java:1343)
     [java]   at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:339)
     [java]   at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:303)
[stopwatch] [run.batch.test.action: 1:24.489 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:471: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:624: Java returned: 1
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1911791569.properties

merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null1593613886

[junitreport] Loading stylesheet ile:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 218ms

[junitreport] Deleting: /tmp/null1593613886

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results

[echo] run.batch.test.tear.down.start.timestamp: 09-15-2025 00:42:57:700 PDT

[stopwatch] [run.batch.test.tear.down: 0.000 sec]

[typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Report:jenkins-report.html
Jenkins Suite:sf
Testray Routine:EE Pull Request
Testray Build ID:316676562

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 21 out of 31 jobs passed in 2 hours 29 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1277401_14958

Base Branch:

Branch Name: master
Branch GIT ID: b8ffc3ea27fa379a103881d9d97110ffafb33ca8

Upstream Comparison:

Branch GIT ID: ebe8a4256d771afaee5aab7e139376339c8c2e79
Jenkins Build URL: EE Development Acceptance (master) - 1643 - 2025-09-11[08:48:35]

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
    ci:test:relevant - 21 out of 31 jobs PASSED

    10 Failed Jobs:

    21 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      6. ...

      For upstream results, click here.

      Test bundle downloads:

      @liferay-continuous-integration
      Copy link
      Collaborator

      @izaera
      Copy link
      Collaborator Author

      izaera commented Sep 15, 2025

      ci:report:316732536

      @liferay-continuous-integration
      Copy link
      Collaborator

      Test suite default has been triggered on http://test-1-25

      @liferay-continuous-integration
      Copy link
      Collaborator

      Build completed.

      Testray CSV has been generated successfully for testrayBuildID: 316732536.

      Job Link: generate-testray-csv

      Testray CSV Link: testray-results-316732536.csv

      @fortunatomaldonado fortunatomaldonado mentioned this pull request Sep 22, 2025
      Open
      @dsanz
      Copy link
      Collaborator

      dsanz commented Oct 6, 2025

      see #5089

      @dsanz dsanz closed this Oct 6, 2025
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Reviewers

      @liferay-frontend liferay-frontend Awaiting requested review from liferay-frontend liferay-frontend will be requested when the pull request is marked ready for review liferay-frontend is a code owner

      Assignees

      No one assigned

      Labels

      ci:test - success ci:test:relevant - failure ci:test:sf - failure ci:test:stable - success

      Projects

      None yet

      Milestone

      No milestone

      Development

      Successfully merging this pull request may close these issues.

      3 participants

      @izaera @liferay-continuous-integration @dsanz