Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] improve ember compatibility #166

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jun 29, 2024

Copy link

netlify bot commented Jun 29, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit b64e3cf
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/668074aafb8bf200086ebbe5
😎 Deploy Preview https://deploy-preview-166--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jun 29, 2024

Code Coverage Report

Coverage after merging improve-ember-compatibility into master

79.04%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts79.596, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.1283.3317, 26
tests
   utils.ts96.1930, 87, 88, 89, ...
utils
   component.ts95.978, 80, 82, 9, ...
   context.ts21
   dom-api.ts96.8825, 39, 40, 41, ...
   dom.ts98.4292.86909, 923, 924, 997, ...
   reactive.ts97.0647, 61, 66, 67, ...
   runtime.ts11
   shared.ts73, 89, 95, 98, ...
   vm.ts24, 4
utils/benchmark
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
utils/control-flow
   if.ts72.3576.9276, 96, 97, 98, ...
   list.ts94.058071, 75, 76, 77, ...
utils/helpers
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts66.672, 3, 4
utils/inspector
   ember-inspector.ts14.70096, 97, 98, 99, ...
   index.ts33.33096, 97, 98, 99, ...
utils/ssr
   rehydration-dom-api.ts52.3896, 97, 98, 99, ...
   rehydration.ts148, 34, 37, 74, ...

@lifeart lifeart merged commit d298ab6 into master Jun 29, 2024
8 checks passed
@lifeart lifeart deleted the improve-ember-compatibility branch June 29, 2024 20:56
Copy link

duration phase estimated regression +118ms [2ms to 238ms] OR +0.88% [0.01% to 1.78%]
renderEnd phase no difference [-1ms to 2ms]
render1000Items1End phase estimated regression +18ms [9ms to 28ms] OR +2.29% [1.16% to 3.5%]
clearItems1End phase no difference [-3ms to 2ms]
render1000Items2End phase no difference [0ms to 16ms]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase estimated regression +30ms [7ms to 51ms] OR +0.92% [0.22% to 1.55%]
clearManyItems1End phase no difference [-2ms to 8ms]
render5000Items2End phase estimated regression +51ms [23ms to 79ms] OR +1.6% [0.72% to 2.51%]
clearManyItems2End phase no difference [-4ms to 9ms]
render1000Items3End phase no difference [-14ms to 5ms]
append1000Items1End phase no difference [-40ms to 6ms]
append1000Items2End phase estimated regression +19ms [2ms to 37ms] OR +2.53% [0.25% to 4.91%]
updateEvery10thItem1End phase no difference [0ms to 16ms]
updateEvery10thItem2End phase no difference [0ms to 16ms]
selectFirstRow1End phase estimated regression +2ms [0ms to 4ms] OR +1.38% [0.35% to 3.33%]
selectSecondRow1End phase no difference [-1ms to 0ms]
removeFirstRow1End phase no difference [-12ms to 1ms]
removeSecondRow1End phase no difference [-16ms to 0ms]
swapRows1End phase no difference [-1ms to 1ms]
swapRows2End phase no difference [-1ms to 1ms]
clearItems4End phase no difference [-3ms to 3ms]
paint phase no difference [0ms to 0ms]

[21:43:14] Generating Benchmark Reports [started]
[21:43:19] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant