Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Code refinement for performance #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dxyzx0
Copy link

@dxyzx0 dxyzx0 commented Oct 22, 2020

In model.py

  1. These two for-loops in the model.py lowers the speed of training and testing, since it doesn't utilize broadcasting of matrix operation in torch.
    In main.py and mol_featurizer.py
  2. I trained my model on a larger dataset with protein length up to 2000 and 70w interactions. We should use joblib to load and dump large files.

Further Refinement:
I like this model very much. I use this model for production. Hence, there's my refinement of the code https://github.com/DingXiangYuanZhiXing/transformerCPI_DTA

Remove some redundant for-loop with pytorch build-in functionality.
joblib is more robust for large dataset
joblib is more robust for large dataset
@comeonzyx
Copy link

Hello,i would like to ask that do you have "dataset/celegans_uniprot.csv"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants