Skip to content

fix: do not check zero block root #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix: do not check zero block root #773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/modules/csm/checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,12 @@ def _get_block_roots(self, checkpoint_slot: SlotNumber):
pivot_index = checkpoint_slot % SLOTS_PER_HISTORICAL_ROOT
# The oldest root can be missing, so we need to check it and mark it as well as other missing slots
pivot_block_root = br[pivot_index]
slot_by_pivot_block_root = self.cc.get_block_header(pivot_block_root).data.header.message.slot
calculated_pivot_slot = max(checkpoint_slot - SLOTS_PER_HISTORICAL_ROOT, 0)
is_pivot_missing = slot_by_pivot_block_root != calculated_pivot_slot
if pivot_block_root == ZERO_BLOCK_ROOT:
is_pivot_missing = True
else:
slot_by_pivot_block_root = self.cc.get_block_header(pivot_block_root).data.header.message.slot
calculated_pivot_slot = max(checkpoint_slot - SLOTS_PER_HISTORICAL_ROOT, 0)
is_pivot_missing = slot_by_pivot_block_root != calculated_pivot_slot

# Replace duplicated roots with `None` to mark missing slots
br = [
Expand Down
Loading