Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAULTS] PDG unit tests #986

Merged
merged 31 commits into from
Mar 26, 2025
Merged

[VAULTS] PDG unit tests #986

merged 31 commits into from
Mar 26, 2025

Conversation

solidovic
Copy link

@solidovic solidovic commented Mar 18, 2025 •
edited by Jeday
Loading

image

Unit tests for PDG contract (100% coverage).

Small fixes of the PDG contract:

  • removed _nodeOperator != address(0) checks that are enforced by guarantorOf
  • added missing whenResumed to claimGuarantorRefund
  • refactored proveValidatorWC to check for validator.stage earlier preventing no reason revert when calling on zero address staking vaullt

@solidovic solidovic changed the base branch from master to feat/vaults March 18, 2025 08:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2025 •
edited
Loading

badge

Hardhat Unit Tests Coverage Summary

Filename                                                                Stmts    Miss  Cover    Missing
--------------------------------------------------------------------  -------  ------  -------  -----------------------------------------------------------------------------------
contracts/0.4.24/Lido.sol                                                 205       7  96.59%   754, 759, 802-814, 963-964
contracts/0.4.24/StETH.sol                                                 79       0  100.00%
contracts/0.4.24/StETHPermit.sol                                           15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                         5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                                       36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                                   37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                            512       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                                   72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                         9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                                        5       0  100.00%
contracts/0.6.12/WstETH.sol                                                17       0  100.00%
contracts/0.8.25/Accounting.sol                                            83       5  93.98%   118-121, 340, 368
contracts/0.8.25/interfaces/IDepositContract.sol                            0       0  100.00%
contracts/0.8.25/interfaces/ILido.sol                                       0       0  100.00%
contracts/0.8.25/interfaces/IOracleReportSanityChecker.sol                  0       0  100.00%
contracts/0.8.25/interfaces/IPostTokenRebaseReceiver.sol                    0       0  100.00%
contracts/0.8.25/interfaces/IStakingRouter.sol                              0       0  100.00%
contracts/0.8.25/interfaces/IWithdrawalQueue.sol                            0       0  100.00%
contracts/0.8.25/lib/GIndex.sol                                            33      18  45.45%   22, 34, 55, 63-70, 79, 86-101
contracts/0.8.25/lib/SSZ.sol                                               16      11  31.25%   31-100, 222-235
contracts/0.8.25/utils/AccessControlConfirmable.sol                        30       0  100.00%
contracts/0.8.25/utils/PausableUntilWithRoles.sol                           3       0  100.00%
contracts/0.8.25/vaults/Dashboard.sol                                      86       1  98.84%   378
contracts/0.8.25/vaults/Delegation.sol                                     31       0  100.00%
contracts/0.8.25/vaults/Permissions.sol                                    33       1  96.97%   267
contracts/0.8.25/vaults/StakingVault.sol                                  121       0  100.00%
contracts/0.8.25/vaults/VaultFactory.sol                                   39       0  100.00%
contracts/0.8.25/vaults/VaultHub.sol                                      173      45  73.99%   94, 280, 321-376, 455-465, 500-530, 543-552, 558-573
contracts/0.8.25/vaults/interfaces/IStakingVault.sol                        0       0  100.00%
contracts/0.8.25/vaults/predeposit_guarantee/CLProofVerifier.sol           11       0  100.00%
contracts/0.8.25/vaults/predeposit_guarantee/PredepositGuarantee.sol      147       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                                61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                                   21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                                 72       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                                 128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                            16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                         16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                            22       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                                     28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                         316       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                                        88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                                   146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                                  89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                                        21       0  100.00%
contracts/0.8.9/lib/Math.sol                                                4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                         22      22  0.00%    88-172
contracts/0.8.9/lib/UnstructuredRefStorage.sol                              2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                               190       2  98.95%   154-155
contracts/0.8.9/oracle/BaseOracle.sol                                      89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                                  263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                         91       2  97.80%   138, 315
contracts/0.8.9/proxy/OssifiableProxy.sol                                  17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol               218      50  77.06%   195, 232, 273-286, 306-324, 413-441, 495, 558-561, 569, 578, 586, 697, 702-747, 802
contracts/0.8.9/utils/DummyEmptyContract.sol                                0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                                    31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                                        11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                             23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol                    9       0  100.00%
contracts/common/utils/PausableUntil.sol                                   29       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol                       21      21  0.00%    49-100
TOTAL                                                                    3842     189  95.08%

Diff against master

Filename                                                                Stmts    Miss  Cover
--------------------------------------------------------------------  -------  ------  --------
contracts/0.4.24/Lido.sol                                                  -7      +7  -3.41%
contracts/0.4.24/StETH.sol                                                 +7       0  +100.00%
contracts/0.8.25/Accounting.sol                                           +83      +5  +93.98%
contracts/0.8.25/interfaces/IDepositContract.sol                            0       0  +100.00%
contracts/0.8.25/interfaces/ILido.sol                                       0       0  +100.00%
contracts/0.8.25/interfaces/IOracleReportSanityChecker.sol                  0       0  +100.00%
contracts/0.8.25/interfaces/IPostTokenRebaseReceiver.sol                    0       0  +100.00%
contracts/0.8.25/interfaces/IStakingRouter.sol                              0       0  +100.00%
contracts/0.8.25/interfaces/IWithdrawalQueue.sol                            0       0  +100.00%
contracts/0.8.25/lib/GIndex.sol                                           +33     +18  +45.45%
contracts/0.8.25/lib/SSZ.sol                                              +16     +11  +31.25%
contracts/0.8.25/utils/AccessControlConfirmable.sol                       +30       0  +100.00%
contracts/0.8.25/utils/PausableUntilWithRoles.sol                          +3       0  +100.00%
contracts/0.8.25/vaults/Dashboard.sol                                     +86      +1  +98.84%
contracts/0.8.25/vaults/Delegation.sol                                    +31       0  +100.00%
contracts/0.8.25/vaults/Permissions.sol                                   +33      +1  +96.97%
contracts/0.8.25/vaults/StakingVault.sol                                 +121       0  +100.00%
contracts/0.8.25/vaults/VaultFactory.sol                                  +39       0  +100.00%
contracts/0.8.25/vaults/VaultHub.sol                                     +173     +45  +73.99%
contracts/0.8.25/vaults/interfaces/IStakingVault.sol                        0       0  +100.00%
contracts/0.8.25/vaults/predeposit_guarantee/CLProofVerifier.sol          +11       0  +100.00%
contracts/0.8.25/vaults/predeposit_guarantee/PredepositGuarantee.sol     +147       0  +100.00%
contracts/0.8.9/Burner.sol                                                 +1       0  +100.00%
contracts/0.8.9/LidoLocator.sol                                            +4       0  +100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                          0     +22  -100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol               -14     +50  -22.94%
contracts/common/utils/PausableUntil.sol                                  +29       0  +100.00%
TOTAL                                                                    +826    +160  -3.96%

Results for commit: 9e5ae84

Minimum allowed coverage is 90%

♻️ This comment has been updated with latest results

@tamtamchik tamtamchik added tests When it comes to testing the code vaults labels Mar 18, 2025
@tamtamchik tamtamchik changed the title (WIP) [Vaults] Feat/vaults pdg tests feat: vaults PDG tests Mar 18, 2025
solidovic and others added 24 commits March 19, 2025 16:47
@solidovic
feat(negative proof flow): intermediate
3813620
@solidovic
feat(negative proof flow): intermediate
e715688
@solidovic
feat(negative proof flow): intermediate
22ecfa4
@solidovic
feat: negative proof flow
ba886c9
@solidovic
feat(negative proof flow): check the ValidatorCompensated event
fa07b1e
@solidovic
feat(negative proof flow): check status
bdee321
@solidovic
feat(negative proof flow): check status
a9b32ed
@solidovic
feat(positive proof flow): check the proveUnknownValidator
eeb08ef
@solidovic
fix: naming
15631d7
@Jeday
Merge branch 'feat/vaults' of github.com:lidofinance/core into feat/v…
37486bb 
…aults-pdg-tests
@Jeday
test: pdg set guarantor and refund
62af36c
@Jeday
fix: add missing whenResumed
183dadb
@Jeday
test: predeposit reverts
35d2fd3
@solidovic
feat: add event checker to proveInvalidValidatorWC
9b068a5
@solidovic
chore: remove comment
40d4b7d
@solidovic
feat: add event checker to topUpNodeOperatorBalance
92c1cac
@Jeday
fix: remove excess check
1029e2d
@Jeday
Merge branches 'feat/vaults-pdg-tests' and 'feat/vaults-pdg-tests' of…
75bbf56 
… github.com:lidofinance/core into feat/vaults-pdg-tests
@Jeday
fix: remove excessive check
da7595d
@solidovic
feat: add a reverting the proveUnknownValidator if it was called by N…
cffa1fa 
…otStakingVaultOwner
@solidovic
Merge remote-tracking branch 'origin/feat/vaults-pdg-tests' into feat…
fba196f 
…/vaults-pdg-tests
@solidovic
feat: add a reverting the compensateDisprovenPredeposit
9af118d
@solidovic
feat: add a reverting the proveUnknownValidator
c55d072
@solidovic
feat: add a reverting the proveInvalidValidatorWC
82ece2d
@Jeday Jeday changed the title feat: vaults PDG tests [vaults] PDG unit tests Mar 25, 2025
@Jeday Jeday changed the title [vaults] PDG unit tests [VAULTS] PDG unit tests Mar 25, 2025
@Jeday Jeday marked this pull request as ready for review March 25, 2025 12:45
@Jeday Jeday requested a review from a team as a code owner March 25, 2025 12:45
tamtamchik
tamtamchik requested changes Mar 25, 2025
View reviewed changes
Copy link
Member

@tamtamchik tamtamchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done a great work, you have!
Although some structural comments I have. Herh herh herh.

tamtamchik
tamtamchik approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@tamtamchik tamtamchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

@tamtamchik tamtamchik merged commit b20b549 into feat/vaults Mar 26, 2025
9 checks passed
@tamtamchik tamtamchik deleted the feat/vaults-pdg-tests branch March 26, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeday Jeday Jeday left review comments

@tamtamchik tamtamchik tamtamchik approved these changes

Assignees
No one assigned
Labels
tests When it comes to testing the code vaults
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solidovic @tamtamchik @Jeday