feat: self-impose locks on StakingVault #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failingtwice
force-pushed
the
selfimposed-lock
branch
from
14cb780 to
0a51796
Compare
folkyatina
reviewed
Mar 19, 2025
| function lock(uint256 _locked) external { | ||
| if (msg.sender != address(VAULT_HUB)) revert NotAuthorized("lock", msg.sender); | ||
|
|
||
| function lock(uint256 _locked) external onlyOwner { |
There was a problem hiding this comment.
In this configuration, it's possible to enforce _locked <= valuation, but it means that we should prefund 1 ETH in vault factory for deposit, which is fine tbh.
failingtwice
force-pushed
the
selfimposed-lock
branch
from
bda4fe4 to
57d4943
Compare
…o selfimposed-lock
tamtamchik
changed the title
TheDZhon
approved these changes
Apr 1, 2025
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: d6587f9 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shifts the responsibility of locking amount on the vault from VaultHub to the vault owner (outside of reports).
Problem
Prevents the VaultHub from locking arbitrary amount on the vault
Solution
Locked amount is controlled by the owner. Now minting only checks (instead of locking) that there is a sufficient locked amount on the vault.
TODO: VaultHub can still lock an arbitrary amount in report. Think about sanity checks (max lock increase during report)