feat(providers): add documented BigModel Responses preset - #3828
Conversation
Narrowed carry of jamespan’s PR #3641, source origin/axis2-source-3641 at b675d83. Reconstruct the separate Responses preset using only the two models in the official Codex example: https://docs.bigmodel.cn/cn/coding-plan/tool/codex.md (checked 2026-09-07). Keep liveModels false and preserve custom destinations and Responses reasoning replay. Map exact context windows, effort ladders, max defaults, summary support, and text modalities. Do not carry model-discovery.ts or envelopeKey/idKey; Flash Responses metadata and live discovery remain unverified. Add consumer metadata and custom-transport collision regressions; document the static roster and existing Codex export policy (compatibility ultra on GLM-5.3, omitted default field on Turbo’s empty ladder). Validation: git diff --check passed. Tests, typecheck, lint, and builds intentionally not run per worker scope; parent final CI owns execution. Co-authored-by: jamespan <panjiabang@gmail.com>
Skip undocumented HTTP model-list validation through the existing unknown key-validation policy. Add a zero-fetch regression. For explicitly empty model/provider effort ladders, omit only the Responses effort field and retain reasoning summaries. Preserve omitted requests, nonempty model override precedence, unknown/non-rankable ladders, and forward behavior. Keep the documented Turbo max metadata without adding a selectable tier or injecting a wire default. Existing __omit__ mappings and noReasoningModels policy are unchanged. Add outbound serialization cases for omitted, max and ultra effort, summary preservation, input immutability, and unchanged consumer paths. Regenerate model metadata; the generated delta is only the BigModel Responses to zai alias. Validation: bun run generate:model-metadata and git diff --check passed. No tests, typecheck, lint or builds run; commit hooks skipped to honor that restriction. Main final CI and separate independent review remain required. Co-authored-by: jamespan <panjiabang@gmail.com>
First CI run 34064726690 reports text,image rather than text for both BigModel models at provider-registry-parity.test.ts:471; the Turbo effort array remains empty. Source tracing confirms applyProviderConfigHints uses isModelVisionSidecarConsumer, also used by the runtime vision planner, to expose image attachment support for configured text-only models. Keep the official text-only registry declarations and assert them independently before checking the bridge-enriched model and final catalog modalities. Preserve exact Turbo empty effort expectations and all generic modality behavior. Clarify that image handling requires the existing available, enabled vision sidecar rather than native BigModel image support. Validation: supplied CI failure log and source contract reviewed; git diff --check passed. No local tests, typecheck, lint or builds run. Commit hooks skipped per execution restriction. Main final CI and independent review remain required. Co-authored-by: jamespan <panjiabang@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 54 / 80이 PR은 Axis2 체인의 BigModel 기초 층이다. 베이스 "no new providers" 비목표와 겹쳐 보이는 지점을 먼저 말한다. 레지스트리에 새 id가 생긴 것은 맞다. 다만 작성 의도는 그린필드 제공자가 아니라, 이미 있는 BigModel 계열의 Responses 문서 프리셋이다. 어댑터 쪽 핵심은 범위 밖으로 안 나간 점도 명확하다. Flash 미포함, live discovery 없음, Chat 엔드포인트( 라인 registry.ts zhipu-bigmodel-responses - 새 레지스트리 행이 "문서 프리셋"인지 "새 제공자 추가"인지 릴리즈 노트 문장을 고정해야 한다. 사용자 피커에 세 번째 BigModel 항목이 생기는 UX 비용이 있다. 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
CI 34065098625 and 34065112182 exposed a numeric-effort fixture rejected by parseRequest before it reaches the adapter. Use schema-valid high effort to exercise provider-wide omission and input immutability; preserve strict ingress validation. No production change and no local suites. Co-authored-by: jamespan <panjiabang@gmail.com>
|
✅ Deterministic PR hygiene checks passed. |
|
Owner-directed admin merge exception: the maintainer explicitly requested merging this manual PR chain now despite the final CI runner queue. Independent source/security reviews and the fixture correction review passed. Local test suites were not run by explicit maintainer instruction. Final combined-head CI runs 34066142241 and 34066144401 remain queued at 95edd0a; these are NOT reported as passing. Earlier failed attempts were repaired and remain historical failed/superseded evidence. Merge #3828 then retarget #3829 to dev and merge it. Use merge commits to preserve original contributor credit; do not delete source branches. No GitHub native stack is registered. This is an explicit CI/review-requirement bypass for this landing, not a claim of successful final CI. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 participant
Summary
Add a separate BigModel Coding Plan Responses preset using the endpoint and two-model static catalog documented in the official Codex guide. Preserve custom destinations, model context/effort metadata and Responses reasoning replay. This carries the verified subset of #3641; HTTP model discovery and Flash metadata remain deferred. Skip the undocumented login probe and omit unsupported raw effort for explicitly empty Responses ladders.
Source: #3641 at b675d83. Original contributor: @jamespan. Implementation commits retain the Co-authored-by trailer.
Manual delivery chain: this foundation targets dev; Raycast #3829 follows as a child. No GitHub native stack registration. The features are independent; this is the owner-requested review/delivery order for a combined final CI.
Verification
Checklist
Co-authored-by: jamespan panjiabang@gmail.com