Bookmark Games #868
Closed
Bookmark Games #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZTL-UwU <[email protected]>
Signed-off-by: ZTL-UwU <[email protected]>
Signed-off-by: ZTL-UwU <[email protected]>
Signed-off-by: ZTL-UwU <[email protected]>
Signed-off-by: ZTL-UwU <[email protected]>
Signed-off-by: ZTL-UwU <[email protected]>
Signed-off-by: ZTL-UwU <[email protected]>
|
Blocked by #594 (comment) |
ornicar
reviewed
Jul 26, 2024
|
|
||
| Future<void> bookmark(GameId id, {int v = -1}) async { | ||
| // if v is -1, toggle the bookmark value on server | ||
| // otherwise explicitly set the new value |
There was a problem hiding this comment.
If think -1 is a bad idea, better to always explicitly set the new value, than to assume the current server state.
There was a problem hiding this comment.
Yes, this a temporary solution. When the bookmarked field is added I will remove the -1.
|
@ZTL-UwU what is missing here to complete this feature? I think we can move on now since lichess-org/lila#15773 has been merged. Also can you please fix the conflicts? Thanks. |
|
Yes, we can move on now. I'm just a bit busy irl. I'll pick it up once I have some free time. |
Thanks, go ahead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #594