-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bookmark games #1302
Closed
Closed
Bookmark games #1302
Changes from 26 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
2d34caf
feat: bookmark in game list context menu
ZTL-UwU c58e691
feat: game history bookmark slidable
ZTL-UwU e8ef9b6
chore: remove unused import & var
ZTL-UwU b8ed607
chore: remove unused import
ZTL-UwU 8083469
feat: bookmark button in game screens
ZTL-UwU 0ccc01f
feat: bookmark action in game history slidable
ZTL-UwU 56fccaa
feat: bookmark action in game analysis
ZTL-UwU f1e26e9
Merge branch 'main' into main
ZTL-UwU 40ef91a
Merge upstream into bookmark-games
julien4215 52c9fce
Add bookmark translation
julien4215 50ccaf2
More work on game bookmark
julien4215 47878d7
Merge upstream into bookmark-games
julien4215 fa5ca9f
Add bookmark state on game history screen
julien4215 3c9bd14
Merge upstream into bookmark-games
julien4215 90511bb
Add a provider to know if user is logged in
julien4215 38b715d
Show an error message if bookmark fails
julien4215 42411a4
Simplify bookmark method in game repository
julien4215 8d1b28d
Use isLoggedIn provider instead of watching authSessionProvider
julien4215 1b7deb5
Remove bookmark button on analysis screen
julien4215 3a68579
Change color of slidable to match theme
julien4215 653a168
More work on bookmarks
julien4215 ea8dfc2
Merge upstream main branch into bookmark-games
julien4215 d1aa50e
Introduce a new bookmark provider to solve sync issues between providers
julien4215 f142db1
Add bookmark functionality to archived game screen and game screen
julien4215 95b6299
Rename provider and add a doc comment to the provider
julien4215 2c8bdfb
Tweak bookmarks
julien4215 b057274
Merge upstream into bookmark-games to get the cache removal of games
julien4215 762bfa2
Merge upstream to fix conflicts
julien4215 0c2f3a7
Use a drop down menu for bookmark on game screens
julien4215 a2e007b
Add bookmark to recent games widget
julien4215 2eb1d11
Merge upstream into bookmark-games for CI test
julien4215 01ba938
Tweak code
julien4215 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import 'package:lichess_mobile/src/model/common/id.dart'; | ||
import 'package:riverpod_annotation/riverpod_annotation.dart'; | ||
|
||
part 'game_bookmark_provider.g.dart'; | ||
|
||
/// A provider to store the bookmark value of a game when it was changed by the user. | ||
@Riverpod(keepAlive: true) | ||
class GameBookmark extends _$GameBookmark { | ||
@override | ||
bool? build(GameId id) => null; | ||
|
||
@override | ||
set state(bool? newState) => super.state = newState; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This provider looks dubious, I think it is not necessary and this state can be store elsewhere (probably a transient widget state is enough).