-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [BoardEditor] add reset board and starting position option #1035
base: main
Are you sure you want to change the base?
Conversation
Should I also add an option to |
06ed5f1
to
2047b5c
Compare
These new buttons should not be placed here, and should not look like a chip. They are action buttons (clear board) where the other ones are toggles on the current position. We should rearrange as follow imo:
|
We could, but we already have the "Load position" screen which achieves the same. More interesting is to add the choice picker to choose a preconfigured opening or endgame position like in the website. |
I'm not sure about the settings icon on the top nav bar. I'd expect these settings to be configuration for the board editor itself (like configuring behavior of the editor), and they actually are position related, switches to change the FEN output. So the button should not be placed on top imo, but I agree that the settings (cog) icon is not a good choice either. Maybe we should just revert to the 'tune' icon and put it back at the bottom. Not entirely satisfied with the tune icon but I cannot find any better one. |
Implements #1010
Screenshot: