Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify scalac options with tpolecat setting #340

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Unify scalac options with tpolecat setting #340

merged 1 commit into from
Aug 21, 2024

Conversation

lenguyenthanh
Copy link
Member

Exception -Wsafe-init which needs upstream library to fix it.

@lenguyenthanh
Unify scalac options with tpolecat setting
99d3487 
Exception -Wsafe-init which needs upstream library to fix it.
@lenguyenthanh lenguyenthanh merged commit 8c0eb2f into master Aug 21, 2024
2 checks passed
@lenguyenthanh lenguyenthanh deleted the unify-scalac-options branch August 21, 2024 13:37
@Masynchin
Copy link
Contributor

Is ScalacOption used? I can only see ScalacOptions references. Or there is an implicit usage? And in the case of unused import, is CI set to catch it?

@lenguyenthanh
Copy link
Member Author

Is ScalacOption used? I can only see ScalacOptions references.

No, this is a left over while I was experimenting with it.

And in the case of unused import, is CI set to catch it?

ideally, CI should catch it but apparently no, I'll take a look at this later.

Thanks @Masynchin for looking!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenguyenthanh @Masynchin