Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new notifications #2273

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

schlawg
Copy link
Contributor

@schlawg schlawg commented Dec 22, 2022

No description provided.

@veloce
Copy link
Collaborator

veloce commented Dec 23, 2022

There a lot of indentation changes. The only change really is:

          default: {
             const url = action.notification.data['lichess.url'] as string
             if (url?.startsWith('https://lichess.org/')) {
               void openExternalBrowser(url)
             }
           }

right?

@schlawg
Copy link
Contributor Author

schlawg commented Dec 23, 2022

correct.

sorry about the indentation i didn't have my editor hooked up to the lichobile defaults

@schlawg
Copy link
Contributor Author

schlawg commented Dec 23, 2022

there is also probably an import openExternalBrowser at the top

@veloce
Copy link
Collaborator

veloce commented Jan 3, 2023

So the default behaviour is to open the browser within the app when one taps on a notif. I make sense for "streamer goes live" and maybe "study invite", but for "tournament starting soon" it's weird since the tournaments are in the app.

Could we not open the tournament in the app instead?

@schlawg
Copy link
Contributor Author

schlawg commented Jan 3, 2023

That's absolutely your call. If there was a change to tournament starting soon behavior, it was unintentional

@veloce
Copy link
Collaborator

veloce commented Jan 4, 2023

Isn't "tournamentStartingSoon" a new notification? the app never supported it.

@schlawg
Copy link
Contributor Author

schlawg commented Jan 4, 2023

Not sure. That one predates my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants