-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for new notifications #2273
base: master
Are you sure you want to change the base?
Conversation
launching in an unauthenticated browser session.
will be needed if/when lichess-org/lila#11859 is merged.
…-streamstart-add-mention
…-streamstart-add-mention
There a lot of indentation changes. The only change really is:
right? |
correct. sorry about the indentation i didn't have my editor hooked up to the lichobile defaults |
there is also probably an import openExternalBrowser at the top |
So the default behaviour is to open the browser within the app when one taps on a notif. I make sense for "streamer goes live" and maybe "study invite", but for "tournament starting soon" it's weird since the tournaments are in the app. Could we not open the tournament in the app instead? |
That's absolutely your call. If there was a change to tournament starting soon behavior, it was unintentional |
Isn't "tournamentStartingSoon" a new notification? the app never supported it. |
Not sure. That one predates my changes. |
No description provided.