MacOS: improve scroll smoothing #13036
Open
+5
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use scrollingDelta instead of delta, as recommended by the Apple documentation. It gives much smoother scrolling.
|
There's some interaction with trackpad scrolling here, so this needs further review. |
|
I only tested with the macOS trackpad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use scrollingDelta instead of delta, as recommended by the Apple documentation. It gives much smoother scrolling.
I'm switching from glfw to sdl and I noticed the scrolling is very janky in SDL on macos (very few wheel events).
Empirically, I noticed glfw multipling by 0.1 if hasPreciseScrollingDeltas is on, and it indeed gives me similar speed to delta (but much smoother).
Note: I don't think the ceil/floor is needed anymore if hasPreciseScrollingDeltas is false, but I'm not 100% sure as my macbook supports hasPreciseScrollingDeltas. In the end I did the same as in glfw