Add missing SDL_GPU_TEXTUREFORMAT_R8_INT to SDL_GPUTextureFormatTexel… #12151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slouken
reviewed
Feb 1, 2025
| @@ -605,6 +605,7 @@ Uint32 SDL_GPUTextureFormatTexelBlockSize( | |||
| case SDL_GPU_TEXTUREFORMAT_R8_SNORM: | |||
| case SDL_GPU_TEXTUREFORMAT_A8_UNORM: | |||
| case SDL_GPU_TEXTUREFORMAT_R8_UINT: | |||
| case SDL_GPU_TEXTUREFORMAT_R8_INT: | |||
There was a problem hiding this comment.
Can you add the other INT formats to this function as well? R16_INT, etc?
There was a problem hiding this comment.
Absolutely, went through and compared and think I got the missing ones now.
coffeechriph
force-pushed
the
add_missing_texture_format
branch
from
928a962 to
7cba35e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…BlockSize
Description
Adds SDL_GPU_TEXTUREFORMAT_R8_INT to the switch together with the other R8 formats.