Feature/lxl 4610 cleanup #1567
Merged
Feature/lxl 4610 cleanup #1567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannistsiroyannis
approved these changes
May 26, 2025
olovy
pushed a commit
that referenced
this pull request
May 26, 2025
* Remove useless check for outgoing links and clean up * Give more informative error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the check for outgoing links and cleaned up related code.
There is no point in checking for outgoing links to deleted records because once a record is deleted its main entity IRI gets removed from
lddb__identifiersand thus we can't see if a record was ever present in lddb via its main entity IRI.Also improved the error message for when trying to delete a referenced record a bit.