standardize usage of video_driver_update_viewport #18481
Merged
+65
−197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warmenhoven
force-pushed
the
warmenhoven/pr/viewport
branch
from
7794fba to
9a51686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
video_driver_update_viewport()is supposed to be able to handle all of the video scaling and aspect ratio settings but right now is only being used by metal and the d3d video drivers. All the other drivers do basically exactly the same thing but inline. This cleans it up a little.Originally this included almost all of the graphics drivers. I've since reduced it to just the ones I've tested directly, so this should be safe. I'll create another PR after this one is merged with the ones I haven't tested yet. For now they can continue without having problems.
I have another smaller more targeted PR coming, to allow overlays to change the position/aspect ratio of the viewport, that uses
video_driver_update_viewport(), so to make it work broadly, it's helpful to have the video drivers actually use it. The ones that haven't been updated just won't be able to have that until they move tovideo_driver_update_viewport().