Hotkeys follow player 1 #18353
Merged
Hotkeys follow player 1 #18353
+469
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g., if user 2 is mapped to core port 0, then hotkeys can be used by user 2 (and only user 2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use hotkeys from core port 0 (player 1). E.g., if user 2 is mapped to core port 0, then hotkeys can be used by user 2 (and only user 2). Hotkey enable and other hotkey buttons must be configured in the autoconfig file for your gamepad.
Works with input remap files or with the feature in my related PR #18331 to map users to core ports on first button press.
Notes:
port. I believe it should bejoy_idxas the autoconf binds are for each gamepad device, not each user. Please let me know if I've misunderstood.Related Pull Requests
Map users to core ports on first button press #18331
Reviewers
@sonninnos (you were mentioned in my other PR).
I hope this will be useful for others. It works for my use case (details in my related PR). Please let me know if there's anything else I should consider.