Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update glib and gstreamer #1327

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Update glib and gstreamer #1327

merged 2 commits into from
Sep 30, 2024

Conversation

yubiuser
Copy link
Contributor

@yubiuser yubiuser commented Sep 6, 2024 •
edited
Loading 

librespot-playback
/workspaces/librespot/playback/Cargo.toml
dependency       current  upgrade
glib             0.19.9   0.20.3
gstreamer        0.22.7   0.23.1
gstreamer-app    0.22.6   0.23.0
gstreamer-audio  0.22.6   0.23.0

The upstream bug has been fixed. Just need to wait before dependencies pick up the new version and it propagates through the crates.

@yubiuser
Copy link
Contributor Author

yubiuser commented Sep 6, 2024 •
edited
Loading

It will take a few days or weeks (and likely a patch update to the dependencies) before librespot will successful build.

@yubiuser yubiuser force-pushed the update/deps branch 2 times, most recently from efea67d to 721a21e Compare September 14, 2024 18:38
@yubiuser yubiuser force-pushed the update/deps branch 2 times, most recently from 639b738 to 7071f3e Compare September 25, 2024 19:11
@yubiuser yubiuser changed the title Update glib and gstreamer Update glib, gstreamer and jack Sep 25, 2024
@yubiuser yubiuser marked this pull request as ready for review September 25, 2024 19:45
@yubiuser
Copy link
Contributor Author

Updating to jack v0.13 would bump the MSRV to 1.80 as it makes use of LazyCell and LazyLock feature which is considered unstable in 1.74. (See https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#lazycell-and-lazylock)

I'm hesitating to upgrade that much...

@roderickvd
Copy link
Member

Looking at the difference between 0.12 and 0.13 I see nothing of particular interest to librespot.

@yubiuser
Copy link
Contributor Author

yubiuser commented Sep 25, 2024 •
edited
Loading

Went back to jack 0.12.

Edit: Turns out also v0.12 already uses LazyCell and LazyLock

@yubiuser yubiuser changed the title Update glib, gstreamer and jack Update glib and gstreamer Sep 26, 2024
@yubiuser
Copy link
Contributor Author

I fored pushed away the jack commits

@roderickvd
Copy link
Member

Thanks. Can you resolve the conflicts? Sorry for merging a later PR first, which caused this probably.

@yubiuser
Update gstreamer
71409b3 
Signed-off-by: yubiuser <[email protected]>
@yubiuser
Update glib
e9c4f4f 
Signed-off-by: yubiuser <[email protected]>
@roderickvd roderickvd merged commit 3781a08 into librespot-org:dev Sep 30, 2024
13 checks passed
@yubiuser yubiuser deleted the update/deps branch September 30, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yubiuser @roderickvd