Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credentials with access token (oauth) #1309
Credentials with access token (oauth) #1309
Changes from 7 commits
7a45614
4956da9
eeec818
ee7ba28
60fae8f
fe4d36b
65a2526
70e2e5f
2354d77
e5f4e68
da0f6a1
e6843d9
0a1fe35
5093a88
4a24bcd
e2421ac
a391a87
f14208e
68eebc8
fd1f618
4dc4157
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving from 0.4 to 0.5 I spent a lot of time making the code panic-free by purging all
unwrap
andexpect
s. Could you have this and the below returnResult
too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I worked through most of this last night. As a part-time Rust contributor, I'm guilty of unwrapping everything rather than handling errors properly so this stuff was a bit new. I probably haven't got it as nice as it could be but it's better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through it. Unless I'm mistaken, I still see quite a lot of code that could panic due to unwrapping. How can I help you set it up to return e.g. a
Result<AuthorizationCode, core::Error>
(the other library parts should offer examples on how to but let me know if you need some pointers).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've worked on doing it but I've yet to push that work as I didn't quite finish. I'll try and sort it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There we go