add flag to display connect device as group #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great to me! Unless there are any other comments, good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
groupStatusflag of the Spotify ZeroConf API and a flag in the CLI to set it.Motivation:
This allows differentiating between single and group devices when you have multiple Librespot instances or Connect devices on your network.
Notes:
The ZeroConf docs show
GROUPandNONEas valid options forgroupStatus.There was no obvious short flag to set for the new
groupflag, so no short flag was set.Verifying:
The new example at
discovery/discovery_group.rs.The command
cargo run -- --name "Librespot Group" --group.Example:
Let me know if you would like any changes!