fix: send correct down signal to socklog, to avoid delay during shutdown#462
Open
elratt0r wants to merge 1 commit intolibrenms:masterfrom
Open
fix: send correct down signal to socklog, to avoid delay during shutdown#462elratt0r wants to merge 1 commit intolibrenms:masterfrom
elratt0r wants to merge 1 commit intolibrenms:masterfrom
Conversation
|
|
elratt0r
force-pushed
the
fix-socklog-signal
branch
from
f357765 to
265d691
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When shutting down librenms in docker/podman, socklog hangs until a KILL is issued by s6-init. With this patch it get's send SIGHUP on shutdown instead of SIGTERM. That makes it terminate clean and not hang.