Fixed a bug in upgrading popupServices settings #829

package.json

@@ -23,8 +23,8 @@
 	},
 	"homepage": "https://libredirect.github.io",
 	"devDependencies": {
-		"web-ext": "^7.2.0",
-		"pug-cli": "^1.0.0-alpha6"
+		"pug-cli": "^1.0.0-alpha6",
+		"web-ext": "^7.2.0"
 	},
 	"webExt": {
 		"sourceDir": "./src/",
@@ -35,4 +35,4 @@
 			"overwriteDest": true
 		}
 	}
-}
+}

src/assets/javascripts/services.js

@@ -551,7 +551,7 @@ function redirect(url, type, initiator, forceRedirection) {
 			}
 			return `${randomInstance}`
 		}
-		case "twineo": 
+		case "twineo":
 		case "safetwitch": {
 			if (url.hostname.startsWith("clips.")) {
 				return `${randomInstance}/clip${url.pathname}${url.search}`
@@ -804,6 +804,13 @@ function processUpdate() {
 					delete options[frontend]
 				}
 			}
+
+			for (const frontend of options.popupServices) {
+				if (!Object.keys(config.services).includes(frontend)) {
+					const i = options.popupServices.indexOf(frontend);
+					if (i > -1) options.popupServices.splice(i, 1);
+				}
+			}
 		}
 		browser.storage.local.set({ options }, () => {
 			resolve()

src/pages/options/widgets/general.js

@@ -99,7 +99,7 @@ resetSettings.addEventListener("click", async () => {
 	location.reload()
 })
 
-let fetchInstancesElement = document.getElementById('fetch-instances')
+const fetchInstancesElement = document.getElementById('fetch-instances')
 fetchInstancesElement.addEventListener('change', event => {
 	setOption('fetchInstances', 'select', event)
 	location.reload()