Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PlayerFragment): smooth out predictive back progress #6870

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FineFindus
Copy link
Contributor

Sets a limit for the maximum progress of the predictive back gesture in the PlayerFragment. Before reaching the maximum progress, the amount of displayed progress is gradually smooth out, such that further progress appears less.
This makes the back gesture behave more like the one used by the bottom-sheets.
Ref: f143e0d

Sets a limit for the maximum progress of the predictive back gesture in
the PlayerFragment. Before reaching the maximum progress, the amound of
displayed progress is gradually smooth out, such that further progress
appears less.
This makes the back gesture behave more like the one used by the
bottom-sheets.
Ref: f143e0d
@Bnyro
Copy link
Member

Bnyro commented Dec 15, 2024

I'm personally not really convinced by this.

The goal is to support "full" predictive back gestures for the other fragments as well so that the previous fragment is shown when the back progress is 100%, as seen in some other Jetpack Compose apps.

Unfortunately there doesn't seem to be an inbuild way to do so with the NavController APIs of Android that we're using.

@FineFindus
Copy link
Contributor Author

I agree, I've been using this for the last couple of days, and it feels slightly out-of-sync with the OS implementation.

The goal is to support "full" predictive back gestures for the other fragments as well so that the previous fragment is shown when the back progress is 100%, as seen in some other Jetpack Compose apps.

I'm confused, that's already the case for the player with the current implementation?

@FineFindus FineFindus marked this pull request as draft December 15, 2024 18:24
@Bnyro
Copy link
Member

Bnyro commented Dec 15, 2024

I'm confused, that's already the case for the player with the current implementation?

Yes, it is, but it's not for the other "normal" fragments such as the ChannelFragment, PlaylistFragment, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants