add: gossipsub metrics spec draft #695
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Don't review just yet. Still WIP
The pull requests adds a new spec for unified operational GossipSub metrics. The discussion started in libp2p/go-libp2p-pubsub#534 and was brought up in one of the P2P collaborator calls.
Different implementations expose different metrics. Some references:
My plan would be to approach this spec iteratively. This means we'll agree on very limited set of metrics first, release the spec and release updates from then on. This contrasts the approach of getting buy in from everyone for a large set of metrics. Rather start small.