add transport interop testing config #1039
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2025 14:32
Signed-off-by: Dave Grantham <[email protected]>
Signed-off-by: Dave Grantham <[email protected]>
Signed-off-by: Dave Grantham <[email protected]>
Contributor
Author
|
This now works with the re-written transport interop testing framework. Yes the tests are failing but that's a different issue with py-libp2p. This is about getting the Docker image building and running. |
Contributor
|
Thanks, @dhuseby, for raising this PR. There are no issues with py-libp2p itself—the difference is that it has basic linting configurations enabled (checking for trailing whitespaces, extra newlines, line length, etc.), unlike the test-plans repo. We usually run: I’d be happy to resolve these—it should take less than half an hour. Please let me know if you’d prefer me to raise a PR against your fork or if you’d like to grant collaborator access so I can fix them directly here. |
Contributor
|
Hi @sumanjeet0012, since I don't have admin access to add collaborators directly, could you please:
Alternatively, if you create a branch and let me know the name, I can pull and push those commits directly to this PR branch. Thanks! |
Contributor
|
@dhuseby I would like to share that we recently had a meeting where we discussed the resolution of the lint issues in this PR #1042 . Both @pacrob and @acul71 have confirmed that this PR successfully addresses the lint issues. wish to share that this PR #1042 will be merged soon. |
lint issue fix
Contributor
|
@sumanjeet0012 has this got Current commit SHA for python-v0.4:
This is set in This commit corresponds to the "Enhance QUIC Connection ID tracking with proactive notification and improved fallback" commit from PR #1046, which includes the QUIC interop fixes we implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dave Grantham [email protected]
What was wrong?
The python transport interop testing configuration files were originally checked into the test-plans repo when they should be in the implementation repo like every other implementation.
How was it fixed?
Added
interop/transport/Dockerfile,interop/transport/ping_test.py, andinterop/transport/pyproject.tomlfor the transport interop testing framework to use.To-Do
Cute Animal Picture