fix: only close stream if it is open #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a guard to the `.close` operation similar to the one on `.abort` that ensures we only close the stream if it is open. The individual `.closeRead`/`.closeWrite` operations already guard on the read/write status of the stream so there's no functional change, we just avoid a bit more async work as those methods return promises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a guard to the
.closeoperation similar to the one on.abortthat ensures we only close the stream if it is open.The individual
.closeRead/.closeWriteoperations already guard on the read/write status of the stream so there's no functional change, we just avoid a bit more async work as those methods return promises.Change checklist