Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove libp2p deps from webrtc transport #2817

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Nov 11, 2024

Moves integration-style testing to integration tests, runs the extra tests against every transport and remove deps that mean a libp2p release causes a webrtc release.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Moves integration-style testing to integration tests, runs the extra
tests against every transport and remove deps that mean a libp2p
release causes a webrtc release.
@achingbrain achingbrain requested a review from a team as a code owner November 11, 2024 19:30
@achingbrain achingbrain merged commit c917314 into main Nov 14, 2024
34 checks passed
@achingbrain achingbrain deleted the chore/remove-libp2p-deps-from-webrtc branch November 14, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant