Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: remove unnecessary error log #3128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

swarm: remove unnecessary error log #3128

wants to merge 1 commit into from

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Dec 30, 2024

There's no reason to log this error here, this is perfectly legal. We can make it a debug statement, but even that seems not useful.

@sukunrt sukunrt requested a review from MarcoPolo December 30, 2024 14:24
MarcoPolo
MarcoPolo approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. But when would you setup no transports and expect anything to work? In other words, would this error log be helpful to users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukunrt @MarcoPolo